Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that set_ticks() affects major/minor ticks independently #27799

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Clarify that set_ticks() affects major/minor ticks independently #27799

merged 1 commit into from
Feb 20, 2024

Conversation

timhoffm
Copy link
Member

Closes #27701.

@timhoffm timhoffm added the Documentation: API files in lib/ and doc/api label Feb 16, 2024
@timhoffm timhoffm added this to the v3.9.0 milestone Feb 16, 2024
@github-actions github-actions bot added topic: ticks axis labels and removed Documentation: API files in lib/ and doc/api labels Feb 16, 2024
dstansby
dstansby reviewed Feb 17, 2024
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original single sentence is clear enough, but I've added a suggestion that makes it even clearer with only the addition of two words. I'm not sure what you've added is adding anything beyond that original sentence?

lib/matplotlib/axis.py Outdated Show resolved Hide resolved
@timhoffm
Copy link
Member Author

You're right. I've followed your suggestion.

@timhoffm timhoffm merged commit 897dd0a into matplotlib:main Feb 20, 2024
45 checks passed
@timhoffm timhoffm deleted the doc-set_ticks branch February 20, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation topic: ticks axis labels
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

[Bug]: axis set_xscale('log') interferes with set_xticks
2 participants
@timhoffm @dstansby