Deactivate sidebar for release notes#27800
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Feb 19, 2024
Merged
Conversation
Member
The release note page is only a structured collection of links to sub-pages. The sidebar would repeat all the titles of the sub-pages and thus basically repeat all the content of the page. Even worse, it does not contain the version sectioning structure of the release notes page itself. To keep the layout the sidebar gets one empty dummy section. If we leave the sidebar completely empty, it will be deactivated and change the layout of the page. Related to matplotlib#27690 (comment)
a88de27 to
abe4479
Compare
Member
Author
|
Agreed, the layout change is undesireable. We can work around that by an empty sidebar -> updated this PR. I would alternatively fine with the restructuring. Note however, that the links on the sidebar (e.g. "Version 3.8.0") would then only go to the index page of that version and you need to click a second link to get to some content. So the sidebar links for the restructured content are not too practical. |
jklymak
approved these changes
Feb 19, 2024
Member
jklymak
left a comment
There was a problem hiding this comment.
This seems good. Could put the front page sidebar in there, but this is fine.
Member
Author
|
I rather leave an empty sidebar. The front page sidebar has cheatsheets and the donate button, which are out of scope in the changelog context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The release note page is only a structured collection of links to sub-pages. The sidebar would repeat all the titles of the sub-pages and thus basically repeat all the content of the page. Even worse, it does not contain the version sectioning structure of the release notes page itself.
It's thus best to deactivate the sidebar here.
Related to #27690 (comment)