Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pybind11 string formatter for exception messages #27868

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Use pybind11 string formatter for exception messages #27868

merged 1 commit into from
Mar 7, 2024
+15 −14

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 6, 2024

PR summary

This can eventually be replaced by std::format when we require C++20.

PR checklist

@QuLogic
Use pybind11 string formatter for exception messages
9356137 
This can eventually be replaced by `std::format` when we require C++20.
@ianthomas23 ianthomas23 merged commit 9cad0d5 into matplotlib:main Mar 7, 2024
41 of 42 checks passed
@QuLogic QuLogic deleted the pybind11-str-format branch March 7, 2024 08:35
@QuLogic QuLogic added this to the v3.9.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@ianthomas23 ianthomas23 ianthomas23 approved these changes

Assignees
No one assigned
Labels
GUI: tk topic: images
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@QuLogic @tacaswell @ianthomas23