Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Restore D213 in flake8 #27904

Merged
merged 1 commit into from
Mar 11, 2024
Merged

FIX: Restore D213 in flake8 #27904

merged 1 commit into from
Mar 11, 2024

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm added this to the v3.9.0 milestone Mar 10, 2024
.flake8 Outdated Show resolved Hide resolved
@tacaswell
Copy link
Member

The py39 osx failure looks like an install failure (that I can not get my github and work msft accounts to play nice to allow me to restart...)

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on green.

@rcomer rcomer merged commit 76d5838 into matplotlib:main Mar 11, 2024
42 checks passed
@timhoffm timhoffm deleted the flake8-D213 branch March 11, 2024 08:14
@rcomer
Copy link
Member

rcomer commented Mar 11, 2024

I also got "you don't have permissions" when I tried to restart the failed test within Azure, which is odd as I'm sure I did it with the same MS account a couple of days ago. However, I found a button within GitHub that I hadn't spotted before. It's in the sidebar after you click on one of the Azure task "details" links.

image

@QuLogic
Copy link
Member

QuLogic commented Mar 11, 2024

i've never set up an account for Azure, but the button on the sidebar there has always worked for me, so it's probably a better choice overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants