Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix dead link in README #27910

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

AnsonTran
Copy link
Contributor

PR summary

The contribute link in the project's README.md currently links to:
https://matplotlib.org/devdocs/devel/contributing.html

However, this page no longer exists. This PR changes the link to:
https://matplotlib.org/devdocs/devel/contribute.html

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell
Copy link
Member

There should be a re-direct there:

.. redirect-from:: /devel/contributing
.. _contributing:

We should merge this to avoid the redirect in our links, but we should also sort out why the redirect is not working.

@tacaswell tacaswell added this to the v3.9.0 milestone Mar 12, 2024
@tacaswell
Copy link
Member

I'm going to go ahead and merge this and short-circuit the azure and appveyor CI.

@tacaswell tacaswell merged commit 6b91833 into matplotlib:main Mar 12, 2024
31 of 38 checks passed
@tacaswell
Copy link
Member

Thank you @AnsonTran and congratulations on your first merged PR to Matplotlib 🎉

I hope we hear from you again.

@AnsonTran
Copy link
Contributor Author

Thanks @tacaswell !

@AnsonTran AnsonTran deleted the fix-readme-contribute-link branch March 12, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants