Skip to content

Use PyOS_setsig in macos backend#27956

Merged
ksunden merged 1 commit intomatplotlib:mainfrom
QuLogic:macos-setsig
Mar 21, 2024
Merged

Use PyOS_setsig in macos backend#27956
ksunden merged 1 commit intomatplotlib:mainfrom
QuLogic:macos-setsig

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Mar 21, 2024

PR summary

While looking at #27953, we compared 3.7 with 3.8, and noticed the former used PyOS_setsig while 3.8+ uses sigaction.
The docs for this function say it wraps sigaction or signal, and not to use those functions directly.

I believe @ksunden did test this out while trying to see if it would fix anything, and didn't see any change.

PR checklist

The docs for this function say it wraps `sigaction` or `signal`, and not
to use those functions directly.
Copy link
Copy Markdown
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Works as expected testing with ctrl+c locally.

Copy link
Copy Markdown
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I did try this and it worked

@ksunden
Copy link
Copy Markdown
Member

ksunden commented Mar 21, 2024

test failures are likely unrelated, but would like the macos ones to pass on this PR, so reran those. Anyone can merge on green macos CI (I'm ignoring Appveyor, which has been failing on environment creation recently, and does not matter for a mac specific PR)

@ksunden ksunden merged commit 5ab399b into matplotlib:main Mar 21, 2024
@ksunden ksunden added this to the v3.9.0 milestone Mar 21, 2024
@QuLogic QuLogic deleted the macos-setsig branch March 21, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants