Use PyOS_setsig in macos backend#27956
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Mar 21, 2024
Merged
Conversation
The docs for this function say it wraps `sigaction` or `signal`, and not to use those functions directly.
greglucas
approved these changes
Mar 21, 2024
Contributor
greglucas
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up! Works as expected testing with ctrl+c locally.
ksunden
approved these changes
Mar 21, 2024
Member
ksunden
left a comment
There was a problem hiding this comment.
Indeed I did try this and it worked
Member
|
test failures are likely unrelated, but would like the macos ones to pass on this PR, so reran those. Anyone can merge on green macos CI (I'm ignoring Appveyor, which has been failing on environment creation recently, and does not matter for a mac specific PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
While looking at #27953, we compared 3.7 with 3.8, and noticed the former used
PyOS_setsigwhile 3.8+ usessigaction.The docs for this function say it wraps
sigactionorsignal, and not to use those functions directly.I believe @ksunden did test this out while trying to see if it would fix anything, and didn't see any change.
PR checklist