Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyOS_setsig in macos backend #27956

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 21, 2024

PR summary

While looking at #27953, we compared 3.7 with 3.8, and noticed the former used PyOS_setsig while 3.8+ uses sigaction.
The docs for this function say it wraps sigaction or signal, and not to use those functions directly.

I believe @ksunden did test this out while trying to see if it would fix anything, and didn't see any change.

PR checklist

The docs for this function say it wraps `sigaction` or `signal`, and not
to use those functions directly.
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Works as expected testing with ctrl+c locally.

Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I did try this and it worked

@ksunden
Copy link
Member

ksunden commented Mar 21, 2024

test failures are likely unrelated, but would like the macos ones to pass on this PR, so reran those. Anyone can merge on green macos CI (I'm ignoring Appveyor, which has been failing on environment creation recently, and does not matter for a mac specific PR)

@ksunden ksunden merged commit 5ab399b into matplotlib:main Mar 21, 2024
41 of 43 checks passed
@ksunden ksunden added this to the v3.9.0 milestone Mar 21, 2024
@QuLogic QuLogic deleted the macos-setsig branch March 21, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants