typeFace as bytestring in Py3 #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solves the issue for me but it is not clear that it is right. AFAIK typeface should be a ASCII but at least for this font it is not. In any case we don't actually seem to use typeFace for any thing. The only place in the code I can grep it just below where it is created in Py_BuildValue |
|
I think this is probably fine. I have seen other fonts in the wild that don't conform to the TrueType spec in that they have non-ascii characters where they shouldn't. Since we aren't really using this value anywhere, I think this fix is fine. Thanks. |
|
Ok to merge this then? If we can find a Free font in the wild which we can bundle that has this issue we could add a test but I don't know of any such font. The ones that I know of are not free. |
tacaswell
added a commit
that referenced
this pull request
Dec 3, 2014
BUG : typeFace as bytestring in Py3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution to #3849