Update colormap user page #5611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m the docs. Changed grayscale plot to use colorspacious CAM02-UCS instead of CIELAB
…lib into update-colormap-user-page
|
Looks good, Will merge when Travis is happy. Thanks @kthyng |
|
I think this should be backported to 1.5.x so next round of official docs get updated, but if we rebuild the docs for 1.5.0 this change will not be included. Sound reasonable? |
|
👍 |
|
backported as 896d089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address request in PR #5591 by @jenshnielsen to have colorspacious be used for colorspace conversions. I changed the grayscale.py code to do so, and to use the CAM02-UCS colorspace instead of CIELAB and removed the Lfunction part of the docs on colormaps and the code itself because I don't think it is very helpful anymore.