/matplotlib

DOC: Fixed Unicode error in gallery template cache #7436

Merged
merged 1 commit into from Nov 22, 2016
+5 −6

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation sphinx extension
Projects

Done in Reviewing pull requests.

Milestone
  v2.0.0
4 participants
@Kojoley @NelleV @tacaswell @QuLogic
@Kojoley
Member

Kojoley commented Nov 10, 2016

writing additional pages... galleryWARNING: a Unicode error occurred when rendering the page gallery.Please make sure all config values that contain non-ASCII content are Unicode strings.
@Kojoley Kojoley DOC: Fixed Unicode error in gallery template cache 
writing additional pages... gallery
WARNING: a Unicode error occurred when rendering the page gallery.Please make sure all config values that contain non-ASCII content are Unicode strings.

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 61.839%
Details
8a39be4

@Kojoley Kojoley added Documentation sphinx extension labels Nov 10, 2016

NelleV changed the title from DOC: Fixed Unicode error in gallery template cache to [MRG+1] DOC: Fixed Unicode error in gallery template cache Nov 10, 2016

@NelleV
Contributor

NelleV commented Nov 10, 2016

LGTM 👍

@tacaswell tacaswell merged commit f06644d into matplotlib:master Nov 22, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 61.839%
Details

@tacaswell tacaswell added a commit that referenced this pull request Nov 22, 2016

@tacaswell tacaswell Merge pull request #7436 from Kojoley/fix-doc-gallery-cache-unicode-e… 
…rror

DOC: Fixed Unicode error in gallery template cache
 9a8ed26
@tacaswell
Owner

tacaswell commented Nov 22, 2016

backported to v2.x as 9a8ed26

QuLogic added this to the 2.0 (style change major release) milestone Nov 22, 2016

QuLogic changed the title from [MRG+1] DOC: Fixed Unicode error in gallery template cache to DOC: Fixed Unicode error in gallery template cache Nov 22, 2016

@tacaswell tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Nov 24, 2016

@tacaswell tacaswell FIX: workaround py2 unicode issues 
9a8ed26 backported #7436 which fixed a
warning about non explicitly encoded non-ascii characters.

This 'just works' on python3, but we need to explicitly make the string
with the unicode (¶ for the links) as unicode for py2.

We can not use `from __future__ import unicode_literals` due to issues
with shpinx expecting bytes (str) not unicode.
 4a947cf

tacaswell referenced this pull request Nov 24, 2016

Merged

FIX: workaround py2 unicode issues #7509

@tacaswell tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Nov 24, 2016

@tacaswell tacaswell FIX: workaround py2 unicode issues 
9a8ed26 backported #7436 which fixed a
warning about non explicitly encoded non-ascii characters.

This 'just works' on python3, but we need to explicitly make the string
with the unicode (¶ for the links) as unicode for py2.

We can not use `from __future__ import unicode_literals` due to issues
with shpinx expecting bytes (str) not unicode.
 b467001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment