Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixed Unicode error in gallery template cache #7436

Merged

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Nov 10, 2016

writing additional pages... galleryWARNING: a Unicode error occurred when rendering the page gallery.Please make sure all config values that contain non-ASCII content are Unicode strings.

writing additional pages... gallery
WARNING: a Unicode error occurred when rendering the page gallery.Please make sure all config values that contain non-ASCII content are Unicode strings.
@NelleV NelleV changed the title DOC: Fixed Unicode error in gallery template cache [MRG+1] DOC: Fixed Unicode error in gallery template cache Nov 10, 2016
@NelleV
Copy link
Member

NelleV commented Nov 10, 2016

LGTM 👍

@tacaswell tacaswell merged commit f06644d into matplotlib:master Nov 22, 2016
tacaswell added a commit that referenced this pull request Nov 22, 2016
…rror

DOC: Fixed Unicode error in gallery template cache
@tacaswell
Copy link
Member

backported to v2.x as 9a8ed26

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Nov 22, 2016
@QuLogic QuLogic changed the title [MRG+1] DOC: Fixed Unicode error in gallery template cache DOC: Fixed Unicode error in gallery template cache Nov 22, 2016
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Nov 24, 2016
9a8ed26 backported matplotlib#7436 which fixed a
warning about non explicitly encoded non-ascii characters.

This 'just works' on python3, but we need to explicitly make the string
with the unicode (¶ for the links) as unicode for py2.

We can not use `from __future__ import unicode_literals` due to issues
with shpinx expecting bytes (str) not unicode.
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Nov 24, 2016
9a8ed26 backported matplotlib#7436 which fixed a
warning about non explicitly encoded non-ascii characters.

This 'just works' on python3, but we need to explicitly make the string
with the unicode (¶ for the links) as unicode for py2.

We can not use `from __future__ import unicode_literals` due to issues
with shpinx expecting bytes (str) not unicode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants