Commit to fix a broken link #7496
Conversation
| you know the date format string of the date you are parsing. See | ||
| :file:`examples/load_demo.py`. | ||
| you know the date format string of the date you are parsing. | ||
| :file: needs to be updated. |
There was a problem hiding this comment.
If the example doesn't exist anymore, can you please remove the reference to it?
There was a problem hiding this comment.
Alright then will do.
| @@ -274,8 +274,7 @@ def _from_ordinalf(x, tz=None): | |||
| class strpdate2num(object): | |||
| """ | |||
| Use this class to parse date strings to matplotlib datenums when | |||
| you know the date format string of the date you are parsing. See | |||
| :file:`examples/load_demo.py`. | |||
| you know the date format string of the date you are parsing. | |||
There was a problem hiding this comment.
the format string of the date being parsed is known. (May as well remove the second person...?)
There was a problem hiding this comment.
What do you mean by remove the second person?
There was a problem hiding this comment.
The use of you. Granted, this is a personal preference so I wouldn't hold up a merge over it. (Also edited language a bit more)
There was a problem hiding this comment.
@story645 I think quoting the first sentence would have clarified things; at first I thought it was just a statement instead of a suggestion of how to write the sentence.
Current coverage is 62.00% (diff: 100%)@@ master #7496 diff @@
==========================================
Files 109 173 +64
Lines 46636 56028 +9392
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 31043 34739 +3696
- Misses 15593 21289 +5696
Partials 0 0
|
NelleV
changed the title
DOC: Commit to fix a broken link
|
backported to v2.x as 46c0ead @vraelvrangr Thanks! Congratulations on your first mpl contribution 🎉 Hopefully we will hear from you again. We really appreciate documentation PRs! |
QuLogic
changed the title
|
Thank you @tacaswell ! I look forward to contributing more in the future! |
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
So this pull request is to address the issue #7437. As I note in a comment on there, there is no example case for the noted broken link but there is actually an example case for another broken link so here is the fix to that and I put a note in place of the broken link saying that it requires updating.