Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Commit to fix a broken link #7496
Conversation
|
vraelvrangr |
All checks have passed |
9f44c3c
|
| - you know the date format string of the date you are parsing. See | ||
| - :file:`examples/load_demo.py`. | ||
| + you know the date format string of the date you are parsing. | ||
| + :file: needs to be updated. |
NelleV
Nov 21, 2016
Contributor
If the example doesn't exist anymore, can you please remove the reference to it?
|
|
vraelvrangr |
Some checks were not successful |
29f8e43
|
| @@ -274,8 +274,7 @@ def _from_ordinalf(x, tz=None): | ||
| class strpdate2num(object): | ||
| """ | ||
| Use this class to parse date strings to matplotlib datenums when | ||
| - you know the date format string of the date you are parsing. See | ||
| - :file:`examples/load_demo.py`. | ||
| + you know the date format string of the date you are parsing. |
story645
Nov 21, 2016
•
Member
the format string of the date being parsed is known. (May as well remove the second person...?)
story645
Nov 21, 2016
•
Member
The use of you. Granted, this is a personal preference so I wouldn't hold up a merge over it. (Also edited language a bit more)
QuLogic
Nov 22, 2016
Member
@story645 I think quoting the first sentence would have clarified things; at first I thought it was just a statement instead of a suggestion of how to write the sentence.
codecov-io
commented
Nov 21, 2016
•
Current coverage is 62.00% (diff: 100%)@@ master #7496 diff @@
==========================================
Files 109 173 +64
Lines 46636 56028 +9392
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 31043 34739 +3696
- Misses 15593 21289 +5696
Partials 0 0
|
NelleV
changed the title from
Commit to fix a broken link to [MRG] Commit to fix a broken link
Nov 21, 2016
NelleV
changed the title from
[MRG] Commit to fix a broken link to [MRG+1] Commit to fix a broken link
Nov 21, 2016
tacaswell
merged commit fe152fa
into matplotlib:master
Nov 22, 2016
tacaswell
added a commit
that referenced
this pull request
Nov 22, 2016
|
|
tacaswell |
46c0ead
|
|
backported to v2.x as 46c0ead @vraelvrangr Thanks! Congratulations on your first mpl contribution We really appreciate documentation PRs! |
QuLogic
changed the title from
[MRG+1] Commit to fix a broken link to Commit to fix a broken link
Nov 22, 2016
QuLogic
added this to the
2.0.1 (next bug fix release)
milestone
Nov 22, 2016
|
Thank you @tacaswell ! I look forward to contributing more in the future! |
vraelvrangr commentedNov 21, 2016
So this pull request is to address the issue #7437. As I note in a comment on there, there is no example case for the noted broken link but there is actually an example case for another broken link so here is the fix to that and I put a note in place of the broken link saying that it requires updating.