ENH: Added __repr__ for Figure #9379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Oct 13, 2017
lib/matplotlib/figure.py
Outdated
| clsname=self.__class__.__name__, | ||
| h=self.bbox.size[0], w=self.bbox.size[1], | ||
| naxes=len(self.axes), | ||
| ax_plural='is' if len(self.axes) == 1 else 'es' |
There was a problem hiding this comment.
The singular of Axes is Axes (... for matplotlib, Axis is something completely different (sad but true)).
TBH I would just have the suptitle and be done with it.
There was a problem hiding this comment.
Yeah, I think just saying "with one axes" is probably fine and technically more accurate, would it be possible to change that @richardjgowers ?
There was a problem hiding this comment.
@dstansby ok I've changed this
richardjgowers
force-pushed
the
issue-9372-FigureRepr
branch
from
19766d9
to
d443db1
Compare
dstansby
approved these changes
Nov 4, 2017
QuLogic
reviewed
Nov 4, 2017
lib/matplotlib/figure.py
Outdated
| @@ -273,6 +273,13 @@ class Figure(Artist): | |||
| def __str__(self): | |||
| return "Figure(%gx%g)" % tuple(self.bbox.size) | |||
|
|
|||
| def __repr__(self): | |||
| return "<{clsname} size {h:g}x{w:g} with {naxes} axes>".format( | |||
There was a problem hiding this comment.
Capital Axes, though, referring to the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds a better repr to Figure
Eg:
(Maybe) Fixes Issue #9372
Anything else that should go into the repr? Maybe dpi?
Could also do
__str__ == __repr__seeing as they're nearly identical?PR Checklist