Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorials to the Users Guide. #9381

Merged
merged 2 commits into from Oct 12, 2017
Merged

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Oct 12, 2017

PR Summary

Adds tutorials to the user guide.

Addresses #9349 issue of nothing in users guide any more.

Note the heading level for all the tutorial/*/Readme.txt was lowered.

ping @choldgraf

Users Guide

user s_guide_ _matplotlib_2_1_0rc1_post144_dev0_g5645f24e5_documentation

Docs overview

overview_ _matplotlib_2_1_0rc1_post144_dev0_g5645f24e5_documentation

PR Checklist

  • Documentation is sphinx and numpydoc compliant

@choldgraf
Copy link
Contributor

ah that's a nice solution! Can you clarify what the two images are? Are those two different pages in the docs?

@jklymak
Copy link
Member Author

jklymak commented Oct 12, 2017

Upper image is the Users Guide and the lower image is the docs overview. (links here are to current documentation)

@choldgraf
Copy link
Contributor

gotcha - well I am +1 on this and would be in favor of backporting as well

@choldgraf
Copy link
Contributor

@tacaswell maybe we can try out our meeseecks friend on this?

@jklymak jklymak added this to the 2.1.0-docs milestone Oct 12, 2017
@tacaswell
Copy link
Member

Yes, lets see if it works for other branches!

@tacaswell tacaswell merged commit 2f63513 into matplotlib:master Oct 12, 2017
@tacaswell
Copy link
Member

@meeseeksdev backport to v2.1.0-docs

@jklymak jklymak deleted the frontdocs branch October 12, 2017 20:23
@choldgraf
Copy link
Contributor

@Carreau look we're using it!

@choldgraf
Copy link
Contributor

@meeseeksdev say oooooohhhh eeeee!

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 12, 2017

oooooohhhh eeeee!

@choldgraf
Copy link
Contributor

@meeseeksdev backport to v2.1.0-doc

@choldgraf
Copy link
Contributor

@meeseeksdev say ooooeeeee @tacaswell , you gave the wrong branch name!

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 12, 2017

ooooeeeee @tacaswell , you gave the wrong branch name!

tacaswell added a commit that referenced this pull request Oct 12, 2017
@QuLogic
Copy link
Member

QuLogic commented Oct 15, 2017

@tacaswell speaking of wrong branch names, did @meeseeksdev not backport because the branch and milestone are not the same name?

@tacaswell
Copy link
Member

No, it was just because I flubbed the typing, but I think I will change the milestone to match the branch name.

@QuLogic
Copy link
Member

QuLogic commented Oct 15, 2017

No, I meant why it didn't do it automatically (because the milestone was set before the PR was merged.)

@tacaswell
Copy link
Member

The automatic backport is controlled by the on-merge: backport to v2.1.0-doc line in the description of the milestone (which I added after this PR was merged) (see https://github.com/matplotlib/matplotlib/milestones )

I only know how this works because @Carreau was sitting next to me and pointed me to where I needed to edit for the v2.1.1 milestone.

@Carreau
Copy link
Contributor

Carreau commented Oct 15, 2017

I only know how this works because @Carreau was sitting next to me and pointed me to where I needed to edit for the v2.1.1 milestone.

Yeah, I implemented that about 48h before showing it to @tacaswell and need to document it.
I also need to add better error handling when the branch name is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants