Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend_agg cleanup. #9916

Merged
merged 1 commit into from Dec 3, 2017
Merged

backend_agg cleanup. #9916

merged 1 commit into from Dec 3, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 3, 2017

  • Deprecate unused RendererAgg.debug variable.
  • Passing debug=False to _RendererAgg has no effect (PyRendererAgg_init
    actually ignores kwds, and doesn't do anything with debug if it is
    passed positionally either).
  • Moved a comment that was at the wrong line.
  • Wrapped lines to 79 chars; removed allowance in pep8 checker.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
backend_agg cleanup.
5d86d45 
- Deprecate unused RendererAgg.debug variable.
- Passing debug=False to _RendererAgg has no effect (PyRendererAgg_init
  actually ignores kwds, and doesn't do anything with debug if it is
  passed positionally either).
- Moved a comment that was at the wrong line.
- Wrapped lines to 79 chars; removed allowance in pep8 checker.
@dstansby dstansby added this to the v2.2 milestone Dec 3, 2017
@tacaswell tacaswell merged commit aa0f868 into matplotlib:master Dec 3, 2017
@anntzer anntzer deleted the agg-cleanup branch December 3, 2017 21:54
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
backend: agg
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anntzer @dstansby @tacaswell @QuLogic