Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce 3.6.0 and update theme #61

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 20, 2022

And update to 3.6.0 theme.

@QuLogic QuLogic changed the title Announce 3.6.0 Announce 3.6.0 and update theme Sep 20, 2022
@story645
Copy link
Member

Um is the ci fail a problem?

@QuLogic
Copy link
Member Author

QuLogic commented Sep 20, 2022

Ah, same problem as #52.

@story645 story645 linked an issue Sep 20, 2022 that may be closed by this pull request
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It closes #50 😁

@QuLogic
Copy link
Member Author

QuLogic commented Sep 20, 2022

Ah, I messed up the logo link due to copy&paste, I think.

@story645
Copy link
Member

Ah, I messed up the logo link due to copy&paste, I think.

not following?

@QuLogic
Copy link
Member Author

QuLogic commented Sep 20, 2022

Pushed an update so it matches the previous links.

This fixes the search button popup.
@QuLogic
Copy link
Member Author

QuLogic commented Sep 20, 2022

Pushed an additional fix for the search button not popping up. I think pydata-sphinx-theme has better support for landing pages, so we should investigate if we can remove our custom template override sometime in the future.

@timhoffm timhoffm merged commit 80dd51d into matplotlib:main Sep 20, 2022
@QuLogic QuLogic deleted the announce-360 branch September 20, 2022 22:43
@jklymak
Copy link
Member

jklymak commented Sep 21, 2022

This actually looks really bad if the wrapping happens on my machine:

FrontpageIssue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search on homepage
4 participants