Set up ruff & black with pre-commit and document usage
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
commented
May 21, 2023
| # import matplotlib as mpl | ||
| # from matplotlib.backends.backend_qt4agg import FigureCanvasQTAgg as FigureCanvas | ||
| # from matplotlib.backends.qt_compat import QtCore, QtGui | ||
| # | ||
| # def test_editor_add_point(): |
There was a problem hiding this comment.
Pulled all the imports associated with this commented block into the commented block. Any reason to keep this function though?
mfisher87
commented
May 21, 2023
mfisher87
force-pushed
the
code-autoformatting
branch
2 times, most recently
from
9b8bb41
to
9fbf269
Compare
mfisher87
changed the title
mfisher87
changed the title
ruff & black with pre-commit and document usage
mfisher87
commented
May 21, 2023
| f.read(), | ||
| os.path.basename(args.colormap), # noqa: F821 | ||
| "exec", | ||
| ) |
There was a problem hiding this comment.
The FIXME above and noqa comments document a bug found by ruff. Will get back to this when I'm ready to dig into the python loading behavior and build a unit test :)
stefanv
reviewed
May 21, 2023
stefanv
reviewed
May 21, 2023
stefanv
reviewed
May 21, 2023
stefanv
reviewed
May 21, 2023
mfisher87
force-pushed
the
code-autoformatting
branch
from
2321819
to
cf11834
Compare
|
With the pre-commit instructions, should we mention how to install it? |
I think since we link to the docs, people should be able to figure it out. But I don't feel strongly, so happy to add that in if you'd like! |
mfisher87
force-pushed
the
code-autoformatting
branch
from
72f4389
to
8438f66
Compare
mfisher87
force-pushed
the
code-autoformatting
branch
from
8438f66
to
ccf1101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.