Unit test refactor #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
force-pushed
the
unit-test-refactor
branch
from
f86970d
to
d226908
Compare
mfisher87
force-pushed
the
unit-test-refactor
branch
from
d226908
to
355688f
Compare
mfisher87
commented
Jun 3, 2023
| ) | ||
| return act | ||
|
|
||
| def test_editor_loads_jscm_parameters_match(self, colormap_file): |
There was a problem hiding this comment.
This gives us a set of 3 passing tests which just check attributes are as expected, and 3 xfail tests which check actual values loaded from a jscm file.
stefanv
approved these changes
Jun 3, 2023
| @@ -18,52 +18,74 @@ def approxeq(x, y, *, err=0.0001): | |||
| "viscm/examples/sample_diverging_continuous.jscm", | |||
| ], | |||
| ) | |||
| @pytest.mark.xfail(reason="Test very old; intent unclear") | |||
There was a problem hiding this comment.
This looks like a test that ensures that the editor can load a .jscm data file and interpret its values correctly.
There was a problem hiding this comment.
The refactoring looks good.
There was a problem hiding this comment.
This looks like a test that ensures that the editor can load a .jscm data file and interpret its values correctly.
Got that; I'm referring to this assertion here when I say "intent unclear":
assert actual_colors[i][z] == np.rint(expected_colors[i][z] / 256)
Right now I'm not sure why this was ever working :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the unit tests a bit easier to understand by splitting the attribute tests from the colormap value tests. Use
expected/actualterminology to (IMO) improve test readability.Should be rebased after #66 is mergedStill thinking about: how can these chained/dependent PRs be made easier to manage?