Add typechecking #73
Merged
Add typechecking #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
commented
Jun 5, 2023
| # variable`, unless this variable is set: | ||
| MPLBACKEND: "Agg" | ||
|
|
||
| - name: "Install mypy" |
There was a problem hiding this comment.
Added to this workflow because we already have the project dependencies installed here. But we don't have a reason to run mypy on 4 different Python versions (it's configured to target 3.8 in pyproject.toml). Creating a Python environment is expensive, but so is running the type checker. I don't have strong feelings about this tradeoff 🤷 Happy to make this a separate workflow.
stefanv
reviewed
Jun 5, 2023
|
I added some annotations in the previous PR :) I find a typechecker to be a really useful tool for refactoring as well. |
mfisher87
force-pushed
the
add-typechecking
branch
2 times, most recently
from
ac5bc73
to
e02a37d
Compare
mfisher87
force-pushed
the
add-typechecking
branch
from
e02a37d
to
a271a0e
Compare
stefanv
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #72 --
after merging, this branch should be rebased / merged frommainThis PR adds type checking for annotations added in #72