Drop support for Python 3.8, Qt5, matplotlib 3.4, scipy 1.7, numpy 1.21 #75
Conversation
- enum scoping change. - exec vs. exec_. - Matplotlib no longer exports _getSaveFileName (only PyQt4 required a separate _getSaveFileName because it called that function getSaveFileNameAndFilter instead; let's not try to support qt4 anymore). Also, PyQt and PySide use different parameter names for this function; pass parameters positionally instead. - addAction parameter order changed between qt5 and qt6, but we can call it in a way that's compatible with everyone by using setShortcut instead. - QAction moved between qt5 and qt6 but we don't need to explicitly instantiate it; we can use addAction instead to do so.
| "matplotlib", | ||
| "colorspacious", | ||
| "scipy", | ||
| "numpy ~=1.22", |
There was a problem hiding this comment.
Doesn't this also place an upper pin on NumPy?
There was a problem hiding this comment.
Yes, it's equivalent to >=1.22, 1.*, so numpy could not be upgraded to 2.x or higher.
There was a problem hiding this comment.
Ah, the setuptools docs are a bit confusing: wanted to make sure this didn't pin to 22
There was a problem hiding this comment.
Here's some good info "compatible release" specification: https://peps.python.org/pep-0440/#compatible-release
mfisher87
force-pushed
the
pin-minimum-dep-versions
branch
from
62f6857
to
6ceabb6
Compare
Re-integrating changes from <matplotlib#62> Thank you, @anntzer!
mfisher87
changed the title
| libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-xinerama0 libxcb-xfixes0 x11-utils | ||
| xvfb libegl1 \ | ||
| libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-xinerama0 libxcb-xfixes0 x11-utils \ | ||
| libxcb-cursor0 |
There was a problem hiding this comment.
Without libxcb-cursor0, tests failed with Aborted (core dumped) under both PySide6 and PyQt6.
|
I do keep making the same mistakes 😆 I just can't get RST into my fingers like Markdown. I'll plan on doing a post-release PR for that. I'm ready to get this out there. |
Resolves #74
Integrates and closes #62
Closes #59 ; we are using a different interface for instantiating action objects now.