Design new mitm API shape; convert 1 test to this new format to show it #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This design isn't finished yet because there needs to be some helper functions which will automatically implement `callback.Fn` for you, if you want to say "block this request 5 times" or if you want to sniff the `callback.Data` but dont' want to modify it.
kegsay
changed the title
richvdh
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design isn't finished yet because there needs to be some helper functions which will automatically implement
callback.Fnfor you, if you want to say "block this request 5 times" or if you want to sniff thecallback.Databut dont' want to modify it.