Add request query parameter map to instruction struct

[anoadragon453]

This allows passing query parameters to a request while executing an instruction.

This will be useful for e.g sending server_name query parameters while attempting to join a room.

I've confirmed that Dendrite still passes all tests even with this change.

[kegsay]

I don't see the use case here. Instructions are for pre-configuring a HS, which allows referencing via homeserver name e.g hs1. If we want to test ?server_name= then we'd need to write code for it, it wouldn't be done as a blueprint.

[anoadragon453]

@kegsay This came out of #38 and wanting to stick a server_name on the /join/!room:id call that happens during a blueprint setup:

complement/internal/instruction/runner.go

Lines 227 to 234 in cfb058d

	if event.Type == "m.room.member" && event.StateKey != nil &&
	event.Content != nil && event.Content["membership"] != nil {
	membership := event.Content["membership"].(string)
	if membership == "join" {
	path = "/_matrix/client/r0/join/$roomId"
	method = "POST"
	}
	}

If the homeserver doesn't support parsing room IDs for domains then this command will fail.

Perhaps there's a better way to achieve this though?

[kegsay]

Oh I see, is extracting the domain from the room ID non-spec then? I guess we'd need to add in some form of server name to the blueprint then yes.