Application service can join remote federated room without profile set #399
Conversation
| remoteCharlie := deployment.Client(t, "hs2", remoteUserID) | ||
|
|
||
| t.Run("join remote federated room as application service user", func(t *testing.T) { | ||
| //t.Parallel() |
There was a problem hiding this comment.
I see that we have t.Parallel() commented out elsewhere in this file. Do we care about it also being here?
| }) | ||
|
|
||
| // Join the AS to the remote federated room (without a profile set) | ||
| as.JoinRoom(t, roomID, []string{"hs2"}) |
There was a problem hiding this comment.
Test failing in Dendrite. I'm guessing we don't configure application service registrations in it like we do for Synapse.
https://github.com/matrix-org/complement/runs/7116659758?check_suite_focus=true#step:8:415
❌ TestJoinFederatedRoomFromApplicationServiceUser/join_remote_federated_room_as_application_service_user (180ms)
federation_room_join_test.go:547: CSAPI.MustDoFunc response return non-2xx code: 401 Unauthorized - body: {"errcode":"M_UNKNOWN_TOKEN","error":"Unknown token"}
2022/06/29 16:59:07 ============================================
There was a problem hiding this comment.
I thought AS support wasn't fully implemented yet in Complement?
Complement does support configuring application services. For Synapse, that means setting up the registration. But the application service server doesn't work yet. In the tests so far, I've only needed the as_token to do certain actions.
Application service servers not needed/supported until #221 (review)
There was a problem hiding this comment.
Right, okay. Then yeah the Dendrite image won't read the registration files yet. Skip them on Dendrite please.
…without a profile set (#13131) Fix #4778 Complement tests: matrix-org/complement#399
|
I thought AS support wasn't fully implemented yet in Complement? |
MadLittleMods
deleted the
madlittlemods/no-profile-necessary-to-remote-join-as-as
branch
|
Thanks for the review @kegsay 🐊 |
Application service can join remote federated room without profile set
Synapse changes: matrix-org/synapse#13131 to address matrix-org/synapse#4778