Update tests to use the new federation transaction handler #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
kegsay
reviewed
Dec 8, 2020
Update TestOutboundFederationSend and TestOutboundFederationIgnoresMissingEventWithBadJSONForRoomVersion6 to use the new federation transaction handler.
anoadragon453
force-pushed
the
anoa/use_new_federation_handler
branch
from
981a0d3
to
1126afd
Compare
anoadragon453
commented
Dec 8, 2020
kegsay
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following tests to use the new transaction handler introduced in #47:
TestOutboundFederationSend- This test failed with Synapse with the inline transaction handler. Not entirely sure why, the handler function was just never called.TestOutboundFederationIgnoresMissingEventWithBadJSONForRoomVersion6- Synapse will attempt to send presence to the remote homeserver. The test would fail if not expecting this.Based on
#47.