Handle transactions sent during UnverifiableEvents test #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once again Synapse likes to send presence when it joins a room. I wonder if we should perhaps make federation.HandleTransactionRequests default for new servers, with the ability to override it if desired? The only thing I worry about there is that you may want a test that 404's on transactions. Maybe at that point we could just extend HandleTransactionRequests to return custom responses.
13 tasks
|
The entire point of |
kegsay
approved these changes
Jan 6, 2021
anoadragon453
deleted the
anoa/unverifiable_events_test_handle_transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again Synapse likes to send presence when it joins a room. I wonder if we should perhaps make
federation.HandleTransactionRequests(nil, nil)the default for new servers, with the ability to override it if desired?The only thing I worry about there is that you may want a test that 404's on transactions. Maybe at that point we could just extend HandleTransactionRequests to return custom responses.