Add appservices component to docker scripts #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashley Nelson <amn@fantashley.com>
neilalexander
approved these changes
Jun 20, 2020
There was a problem hiding this comment.
Looks like I forgot to commit my cmd/dendrite-user-api-server in #1151 so thanks for filling that gap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashley Nelson amn@fantashley.com
I set up appservice to deploy in docker in order to resolve #515 and I verified it spins up as part of the docker-compose polylith deployment. I also added the binary for
dendrite-user-api-serverbecause the image build script wouldn't complete without it. Please let me know if there's anything I'm missing, thanks!Pull Request Checklist
testfileas specified in docs/sytest.md