Update ACLs when received as outliers #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3008 +/- ##
==========================================
- Coverage 65.77% 63.80% -1.97%
==========================================
Files 507 510 +3
Lines 57292 64142 +6850
==========================================
+ Hits 37682 40929 +3247
- Misses 15802 19168 +3366
- Partials 3808 4045 +237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kegsay
requested changes
Mar 13, 2023
kegsay
approved these changes
Nov 22, 2023
kegsay
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3004 by making sure we also update our in-memory ACLs after joining a new room.
Also makes use of more caching in
GetStateEventBonus: Adds some tests, as I was about to use
GetBulkStateContent, but turns out thatGetStateEventis basically doing the same, just that it only gets theeventTypeNID/eventStateKeyNIDonce and not for every call.