Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe hotserving behaviour for multimedia uploads. #3113

Merged
merged 3 commits into from Jun 15, 2023

Conversation

joshqou
Copy link
Contributor

@joshqou joshqou commented Jun 13, 2023

Return multimedia with a disposition type of attachment instead of inline. NVT#1548992

Signed-off-by: Josh Qou jqou@icloud.com

Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (8cf6c38) 65.65% compared to head (b6692ea) 65.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
- Coverage   65.65%   65.62%   -0.04%     
==========================================
  Files         502      502              
  Lines       55197    55198       +1     
==========================================
- Hits        36242    36221      -21     
- Misses      15216    15231      +15     
- Partials     3739     3746       +7     
Flag Coverage Δ
unittests 49.66% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mediaapi/routing/download.go 61.91% <0.00%> (-0.48%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants