[pseudoIDs] More pseudo ID fixes - Part 2 #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so state events that use user IDs translate to pseudo IDs in pseudo ID rooms - e.g. allowing to query m.room.member by user ID in a pseudo ID room
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3181 +/- ##
==========================================
+ Coverage 64.20% 64.22% +0.01%
==========================================
Files 506 506
Lines 57277 57346 +69
==========================================
+ Hits 36776 36829 +53
- Misses 16636 16651 +15
- Partials 3865 3866 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
- see added TODO for more info
devonh
approved these changes
Aug 24, 2023
wrenix
pushed a commit
to wrenix/dendrite
that referenced
this pull request
Aug 26, 2023
Fixes include: - Translating state keys that contain user IDs to their respective room keys for both querying and sending state events - **NOTE**: there may be design discussion needed on what should happen when sender keys cannot be found for users - A simple fix for kicking guests from rooms properly - Logic for boundary history visibilities was slightly off (I'm surprised this only manifested in pseudo ID room versions) Signed-off-by: `Sam Wedgwood <sam@wedgwood.dev>`
Merged
swedgwood
added a commit
that referenced
this pull request
Sep 8, 2023
In a [previous PR](#3181) I accidentally left GMSL on a dev branch, this PR fixes it by bringing it back to the main branch of GMSL Signed-off-by: `Sam Wedgwood <sam@wedgwood.dev>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Totals before
Totals: 620 passed, 44 expected fail, 118 failedTotals after (0c76e61)
Totals: 643 passed, 49 expected fail, 90 failedFixes include:
Signed-off-by:
Sam Wedgwood <sam@wedgwood.dev>