Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for x86 #3214

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Fix tests for x86 #3214

merged 3 commits into from
Sep 28, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Sep 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b341a66) 65.38% compared to head (baa8433) 65.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
- Coverage   65.38%   65.37%   -0.02%     
==========================================
  Files         507      507              
  Lines       57156    57156              
==========================================
- Hits        37374    37366       -8     
- Misses      15920    15926       +6     
- Partials     3862     3864       +2     
Flag Coverage Δ
unittests 49.46% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
syncapi/storage/postgres/memberships_table.go 77.96% <100.00%> (ø)
syncapi/storage/shared/storage_consumer.go 70.95% <100.00%> (ø)
syncapi/storage/sqlite3/memberships_table.go 77.96% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK marked this pull request as ready for review September 28, 2023 12:48
@S7evinK S7evinK requested a review from a team as a code owner September 28, 2023 12:48
@S7evinK S7evinK changed the title Re-enable x86 tests Fix tests for x86 Sep 28, 2023
@S7evinK S7evinK merged commit 3d02c81 into main Sep 28, 2023
19 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/x86-tests branch September 28, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant