Fix resolve-state
#3229
Merged
Fix resolve-state
#3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3229 +/- ##
==========================================
- Coverage 65.91% 65.89% -0.02%
==========================================
Files 507 507
Lines 57155 57155
==========================================
- Hits 37674 37664 -10
- Misses 15698 15705 +7
- Partials 3783 3786 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kegsay
approved these changes
Oct 5, 2023
danpe
pushed a commit
to globekeeper/dendrite
that referenced
this pull request
Oct 30, 2023
Previously we would "start" the roomserver API, which isn't the best idea, given it also starts processing Jetstream events. We now use a `dummyQuerier` to implement the needed interface for "converting" userID/senderIDs. As per the comment, this **DOES NOT** do any magic for pseudoID rooms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would "start" the roomserver API, which isn't the best idea, given it also starts processing Jetstream events. We now use a
dummyQuerierto implement the needed interface for "converting" userID/senderIDs. As per the comment, this DOES NOT do any magic for pseudoID rooms.