Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks for the device list updater #3251

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Oct 31, 2023

This makes the following changes:

  • Adds two new metrics observing the usage of the DeviceListUpdater workers
  • Makes the number of workers configurable
  • Adds a 30s timeout for DB requests when receiving a device list update over federation

@S7evinK S7evinK added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Oct 31, 2023
@S7evinK S7evinK requested a review from a team as a code owner October 31, 2023 10:44
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (32f7c4b) 65.52% compared to head (7d00753) 65.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
+ Coverage   65.52%   65.54%   +0.02%     
==========================================
  Files         507      507              
  Lines       57198    57209      +11     
==========================================
+ Hits        37481    37500      +19     
+ Misses      15877    15873       -4     
+ Partials     3840     3836       -4     
Flag Coverage Δ
unittests 49.53% <47.05%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/dendrite-demo-pinecone/monolith/monolith.go 77.55% <100.00%> (ø)
cmd/dendrite/main.go 62.23% <ø> (-0.27%) ⬇️
setup/config/config_userapi.go 100.00% <100.00%> (ø)
userapi/userapi.go 72.44% <100.00%> (ø)
userapi/consumers/devicelistupdate.go 44.18% <0.00%> (-5.82%) ⬇️
userapi/internal/device_list_update.go 74.68% <50.00%> (-0.77%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit da7bca0 into main Oct 31, 2023
17 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/device-list-updater branch October 31, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant