Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keydb_server_keys table tests #3270

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Nov 22, 2023

Also moves some of the variable declarations out of the loop to, hopefully, reduce allocations.

@S7evinK S7evinK added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 22, 2023
@S7evinK S7evinK requested a review from a team as a code owner November 22, 2023 09:18
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7863a40) 65.71% compared to head (4cbd956) 65.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3270      +/-   ##
==========================================
+ Coverage   65.71%   65.74%   +0.03%     
==========================================
  Files         507      507              
  Lines       57291    57292       +1     
==========================================
+ Hits        37651    37669      +18     
+ Misses      15830    15812      -18     
- Partials     3810     3811       +1     
Flag Coverage Δ
unittests 49.55% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit 210123b into main Nov 22, 2023
20 checks passed
@S7evinK S7evinK deleted the s7evink/server-keys-table-test branch November 22, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants