Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some content types to be inlined #3274

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Nov 25, 2023

"Shamelessly" stolen from matrix-org/synapse#15988

@S7evinK S7evinK requested a review from a team as a code owner November 25, 2023 18:59
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fd11e65) 65.82% compared to head (6ae9a34) 65.09%.

Files Patch % Lines
mediaapi/routing/download.go 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
- Coverage   65.82%   65.09%   -0.73%     
==========================================
  Files         508      508              
  Lines       57392    57398       +6     
==========================================
- Hits        37776    37363     -413     
- Misses      15803    16109     +306     
- Partials     3813     3926     +113     
Flag Coverage Δ
unittests 49.78% <45.45%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit 185ad6b into main Dec 12, 2023
17 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/content-disposition branch December 12, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant