Fix panic if unable to assign a state key NID #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
the
T-Defect
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
==========================================
- Coverage 65.76% 65.71% -0.06%
==========================================
Files 509 509
Lines 57461 57464 +3
==========================================
- Hits 37790 37763 -27
- Misses 15842 15865 +23
- Partials 3829 3836 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is the added error check before storing the
eventStateKeyNIDin the cache.The panic happens if we attempt to set the cache for
0multiple times, because the cache is immutable.