Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentry reporting #3305

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Update sentry reporting #3305

merged 4 commits into from
Jan 24, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jan 17, 2024

This hopefully reduces the garbage we currently produce.
(Using GlitchTip on my personal instance, this seems to look better)

@S7evinK S7evinK requested a review from a team as a code owner January 17, 2024 20:10
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8e4dc6b) 65.53% compared to head (fa1f1f3) 65.52%.

Files Patch % Lines
federationapi/routing/routing.go 0.00% 2 Missing ⚠️
internal/httputil/httpapi.go 0.00% 2 Missing ⚠️
relayapi/routing/routing.go 0.00% 2 Missing ⚠️
roomserver/internal/input/input_latest_events.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3305      +/-   ##
==========================================
- Coverage   65.53%   65.52%   -0.01%     
==========================================
  Files         509      509              
  Lines       57514    57522       +8     
==========================================
  Hits        37694    37694              
- Misses      15951    15959       +8     
  Partials     3869     3869              
Flag Coverage Δ
unittests 50.11% <53.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't we also want to do this here as well:

hub := sentry.GetHubFromContext(req.Context())

Copy link
Collaborator

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be doing a similar thing everywhere we use CaptureException or CaptureMessage?
The docs would suggest we should (at least everywhere being run inside a goroutine) https://docs.sentry.io/platforms/go/usage/concurrency/

@S7evinK
Copy link
Contributor Author

S7evinK commented Jan 18, 2024

Created #3306 as a follow up task

@S7evinK S7evinK merged commit d58daf9 into main Jan 24, 2024
19 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/sentry2 branch January 24, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants