Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when recaptcha configs are not present #786

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@Trion129
Copy link
Contributor

commented Aug 14, 2019

During setup of Client API if recaptcha is enabled but the settings are missing, error is logged and panic is raised.

Testing:
Enabled enable_registration_captcha, causes error.
Providing keys and api url passes the check and server starts.

@Cnly

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

A better place for these might be:

// check returns an error type containing all errors found within the config
// file.
func (config *Dendrite) check(monolithic bool) error {

@Cnly
Cnly approved these changes Aug 15, 2019
Copy link
Collaborator

left a comment

lgtm

@Cnly Cnly merged commit bf5efbc into matrix-org:master Aug 15, 2019

8 checks passed

buildkite/dendrite Build #251 passed (3 minutes, 9 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-11 Passed (1 minute, 1 second)
Details
buildkite/dendrite/build-slash-go-1-dot-12 Passed (1 minute, 1 second)
Details
buildkite/dendrite/lint-slash-go-1-dot-12 Passed (1 minute, 49 seconds)
Details
buildkite/dendrite/pipeline Passed (9 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-11 Passed (1 minute, 3 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-12 Passed (1 minute, 2 seconds)
Details
ci/circleci: dendrite Your tests passed on CircleCI!
Details
@Cnly

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

Done! I merged it with a slight change to the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.