Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

alertmanager support #249

Merged
merged 1 commit into from Oct 2, 2018
Merged

alertmanager support #249

merged 1 commit into from Oct 2, 2018

Conversation

jcgruenhage
Copy link
Contributor

No description provided.

@turt2live turt2live requested a review from a team October 1, 2018 17:27
@anoadragon453
Copy link
Member

I just meant could it be a security risk ( not sure what data alert manager can produce and if it's sensitive).

@jcgruenhage
Copy link
Contributor Author

I don't think it's sending any sensitive data, but that toally depends on how people configure it

@anoadragon453
Copy link
Member

@jcgruenhage is it worth it to add a config option to disable it?

@jcgruenhage
Copy link
Contributor Author

I don't think so. The bot has access to the messages it sends anyway, since it has a token of a user that is in that room. Also, I can't think of a threatmodel where you'd trust go-neb with the data but not it's logs.. Specifically, for people using it through scalar it will end up on matrix.org anyway, and for people who host it themselves they can just set the loglevel to get rid of it.

@anoadragon453
Copy link
Member

they can just set the loglevel to get rid of it.

I think this covers my issue :)

@jcgruenhage jcgruenhage merged commit 793f79e into master Oct 2, 2018
@Half-Shot
Copy link
Contributor

I hope this was tested, btw?

@jcgruenhage
Copy link
Contributor Author

Yes, it was

@MTRNord
Copy link

MTRNord commented Oct 2, 2018

Just as I dont understand what this does :) What does this in case of Go-Neb? Is it Matrix->Prometheus or the other way around or did I missunderstood it completly?

@turt2live turt2live deleted the jcgruenhage/alertmanager branch October 2, 2018 18:02
@turt2live
Copy link
Member

It's for alertmanager -> matrix

@MTRNord
Copy link

MTRNord commented Oct 2, 2018

@turt2live ok thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants