Remove methods returning/using EventReference
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 55.57% 56.01% +0.43%
==========================================
Files 44 44
Lines 6409 6356 -53
==========================================
- Hits 3562 3560 -2
+ Misses 2510 2460 -50
+ Partials 337 336 -1
☔ View full report in Codecov by Sentry. |
kegsay
approved these changes
May 16, 2023
kegsay
approved these changes
May 17, 2023
…7evink/eventreference
kegsay
reviewed
May 24, 2023
event_builder.go
Outdated
| // Since gomatrixserverlib otherwise deals with EventReferences, | ||
| // take the event IDs out of these and replace the prev_events and | ||
| // auth_events with those new arrays. | ||
| switch prevEvents := eventStruct.PrevEvents.(type) { | ||
| case []string: | ||
| eventStruct.PrevEvents = prevEvents | ||
| case []EventReference: | ||
| case []eventReference: |
There was a problem hiding this comment.
Do we need this? I thought EventFormatV2 == strings only, so this case should never be hit?
kegsay
reviewed
May 24, 2023
event_builder.go
Outdated
|
|
||
| // Base64FromEventID returns, if possible, the base64bytes representation | ||
| // of the given eventID. Returns an empty spec.Base64Bytes if an error occurs decoding. | ||
| func base64FromEventID(eventID string) spec.Base64Bytes { |
There was a problem hiding this comment.
Call this eventHashFromEventID as that is more accurate.
kegsay
approved these changes
May 24, 2023
S7evinK
added a commit
to matrix-org/dendrite
that referenced
this pull request
May 24, 2023
Companion PR to matrix-org/gomatrixserverlib#383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes
CacheCostwhich is now implemented in Dendrite.