Add event size checks similar to Synapse #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 56.95% 58.47% +1.52%
==========================================
Files 50 51 +1
Lines 6632 6993 +361
==========================================
+ Hits 3777 4089 +312
- Misses 2498 2517 +19
- Partials 357 387 +30
☔ View full report in Codecov by Sentry. |
devonh
reviewed
Jul 6, 2023
Comment on lines
247
to
249
| if err := checkID(input.RoomID(), "room", '!'); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Should we also check eventID like synapse does here?
eventV2.go
Outdated
Comment on lines
218
to
235
| if input.StateKey() != nil { | ||
| if l := len(*input.StateKey()); l > maxIDLength { | ||
| if l := utf8.RuneCountInString(*input.StateKey()); l > maxIDLength { | ||
| return EventValidationError{ | ||
| Code: EventValidationTooLarge, | ||
| Message: fmt.Sprintf("gomatrixserverlib: state key is too long, length %d bytes > maximum %d bytes", l, maxIDLength), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| _, persistable := lenientByteLimitRoomVersions[input.Version()] | ||
|
|
||
| if l := len(input.Type()); l > maxIDLength { | ||
| return EventValidationError{ | ||
| Code: EventValidationTooLarge, | ||
| Message: fmt.Sprintf("gomatrixserverlib: event type is too long, length %d bytes > maximum %d bytes", l, maxIDLength), | ||
| Persistable: persistable, | ||
| } | ||
| } |
There was a problem hiding this comment.
We should comment the reasoning behind the 2 checks like synapse does.
devonh
approved these changes
Jul 6, 2023
S7evinK
added a commit
to matrix-org/dendrite
that referenced
this pull request
Jul 7, 2023
Companion to matrix-org/gomatrixserverlib#400 This tries to mimic the logic found in Synapse, as dropping events can break rooms (and we may end up in endless loops..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to mimic the logic from Synapse to allow specific events.