Check if event is rejected before using it for auth #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 58.90% 58.91% +0.01%
==========================================
Files 51 51
Lines 7105 7108 +3
==========================================
+ Hits 4185 4188 +3
Misses 2531 2531
Partials 389 389
☔ View full report in Codecov by Sentry. |
kegsay
approved these changes
Oct 24, 2023
stateresolutionv2.go
Outdated
| authEvents []PDU, | ||
| userIDForSender spec.UserIDForSender, | ||
| isRejected IsRejected, |
There was a problem hiding this comment.
Please rename this to isRejectedFn everywhere. I got very confused and though this was a bool which doesn't make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be even more spec compliant, this adds a
IsRejectedtype/function when resolving state.(Part 2 of #419)