Add a new crypto session state event #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
May 6, 2024
| @@ -59,6 +59,21 @@ | |||
| {"const": "Group", "description": "Modern layout."}, | |||
| {"const": "Compact", "description": "Modern layout with compact option enabled."} | |||
| ] | |||
| }, | |||
| "verificationState": { | |||
There was a problem hiding this comment.
Can you add a description please? Can be copy paste of what's in CryptoSessionState.json.
| ] | ||
| }, | ||
| "recoveryState": { | ||
| "type": "string", |
There was a problem hiding this comment.
Can you add a description please? Can be copy paste of what's in CryptoSessionState.json.
schemas/CryptoSessionState.json
Outdated
| }, | ||
| "required": ["eventName","verificationState", "recoveryState"], | ||
| "additionalProperties": false | ||
| } |
There was a problem hiding this comment.
So IIUC, this Event will be used for state change, so maybe rename to something like CryptoSessionStateChange (not sure what's best)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new CryptoSessionState to get information on Verification And recovery state.
The same propeties are also added as UserProperties.
Adding as UserProperties will allow to have the current state of a user, as the new values will overwrite the previous one (posthog
$set-will replace any value that may have been set on a person for a specific property-)We also keep an event
CryptoSessionStatethat records the historical values (could allow to know the average time to get from unverified to verified, or to check when the state is reverted).For the UserProperty to work as expected, different devices should not report to the same posthog
User. So it depends how platforms are identifyign users