Support enum with whitespaces

[BillCarsonFr]

When using white spaces in oneOf enum types the generated kotlin and swift code was not valid (white space in the property name).

The main changes are in kotlin.py and swift.py, typescript generation was ok with whitespaces.

The change will be invisible for users of the library.

Kotlin

For kotlin, a new field rawValue is added in the generated enum and is used in the getProperties method instead of the enum autogenerated name.

Before:

    enum class VerificationState {
          NotVerified,
          ...
          
          override fun getProperties(): Map<String, Any>? {
               ...
               put("verificationState", verificationState.name)
               ...
          }

After

    enum class VerificationState(val rawValue: String) {
          NotVerified("NotVerified"),
          ...
          
          override fun getProperties(): Map<String, Any>? {
               ...
               put("verificationState", verificationState.rawValue)
               ...
          }

Swift

The enum were alreasy : String just now explicitely adding the rawvalue

Before:

        public enum VerificationState: String {
            ...
            case NotVerified

Now:

        public enum VerificationState: String {
            ...
            case NotVerified = "NotVerified"

[bmarty]

LGTM, thanks. (Can't tell for generated Swift code)

[richvdh]

I suggest making changes to the properties definitions in a separate PR to the changes to the script, to make it easier for reviewers and future readers to see what is changing.

[bmarty]

Yes, you're right, but we do not have the bandwidth to ensure 150% quality on all our projects... Also adding a const with a space in this PR ensure that the change on the script generation works as expected.

I was tempted to tell @BillCarsonFr to better split their commits, for instance I do not like that commit on the script change also contains the generated files. It should be distinct commits, to easily filter out commit with generated code.
But again let's not spend to much time on this.
A better commit history would have been:

• Update the script to support const with spaces
• Run the script
• Update appPlatform names
• Run the script

I guess this can be a better recipe for next time.

[BillCarsonFr]

I force pushed this branch to only contain the script changes with proper history
Script Change 39eeb1c

Run script to modify generated files 641e66f

And there is a new PR to update appPlatform and remove platfromCodeName #106

[richvdh]

Yes, you're right, but we do not have the bandwidth to ensure 150% quality on all our projects.

I think this is a bit like saying "we don't have time to write tests". You can save time in the short term, but in the longer term, breaking up changes into smaller steps that are easier to verify is an important way of avoiding bugs.

[richvdh]

(Thanks @BillCarsonFr for breaking this up - I think it's much clearer now)