This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Add get key request support #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 14, 2017 17:49
Update the sync events to provide the start and the to tokens.
fix invalid test
add promises queue management like the webclient (i.e the keys download request will only trigger a request for the ones which are not yet in progress)
first implementation
fix many issues
Move the download keys promise management into a dedicated class.
add a new unit test
fix an unit test
Add missing copyrights
manuroe
reviewed
Feb 17, 2017
| import java.util.List; | ||
|
|
||
| /** | ||
| * This class describes the device list reponse from a sync request |
| @@ -113,8 +116,9 @@ | |||
|
|
|||
| /** | |||
| * The initial sync is complete and the store can be queried for current state. | |||
| * @param toToken the up-yo sync token | |||
| /** | ||
| * Devices list update | ||
| */ | ||
| public DeviceListResponse device_lists; |
There was a problem hiding this comment.
All other attributes are camelCased. Why not this one?
Update after code review
manuroe
approved these changes
Feb 17, 2017
manuroe
reviewed
Feb 22, 2017
| List<Room> e2eRooms = new ArrayList<>(); | ||
|
|
||
| for(Room r : rooms) { | ||
| if (r.isEncrypted()) { |
There was a problem hiding this comment.
matrix-js-sdk and matrix-ios-sdk ignore any rooms which the user has left
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the e2e devices list refresh from the /sync request
Should fix element-hq/element-web#2305