Display stickers #247
Display stickers #247
Conversation
|
StickerInfo and StickerMessage are c+ped from ImageMessage and ImageInfo. StickerMessage could inherit from imageMessage like this _public class StickerMessage extends ImageMessage { // add custom fields if needed }StickerInfo becomes useless. Moreover, it would simply a lot your UI code which c+p the imageMessage code (in the MediasHelpers) to manage StickerMessages . StickerMessage seems being a custom ImageMessage. |
|
m.sticker isn't a new message type but a new event type. I will try to create a new StickerMessageModel to parse sticker json and inherit of ImageMessage. |
| } else if (TextUtils.equals(Event.EVENT_TYPE_STICKER, event.getType())) { | ||
| StickerMessage stickerMessage = JsonUtils.toStickerMessage(event.getContent()); | ||
|
|
||
| if (stickerMessage.isThumbnailLocalContent()) { |
There was a problem hiding this comment.
As StickerMessage is now a MediaMessage, could we merge this C+P code with the code above?
| @@ -26,6 +26,10 @@ | |||
| public static final String MSGTYPE_FILE = "m.file"; | |||
| public static final String FORMAT_MATRIX_HTML = "org.matrix.custom.html"; | |||
|
|
|||
| // Add, in local, a fake message type in order to StickerMessage can inherit Message class | |||
| // Because sticker isn't a new message type but a new event type without msgtype field | |||
There was a problem hiding this comment.
Can we remove "new" in the comment?
Stickers will be no more new next time we play(code) with them.
| @@ -106,6 +107,8 @@ public CharSequence getTextualDisplay() { | |||
| public CharSequence getTextualDisplay(Integer displayNameColor) { | |||
| CharSequence text = null; | |||
|
|
|||
| Log.e(LOG_TAG, "#getTextualDisplay : " + mEvent.eventId); | |||
| */ | ||
| package org.matrix.androidsdk.rest.model.message; | ||
|
|
||
| public class StickerJsonMessage { |
There was a problem hiding this comment.
Could we have a comment for this class?
Explaining that it is just here as an intermediate object to create a StickerMessage from a m.sticker event type.
Remove dev log
| @@ -727,7 +729,7 @@ public void removeMediasBefore(final Context context, final long timestamp) { | |||
| if (null != events) { | |||
| for (Event event : events) { | |||
| try { | |||
| if (TextUtils.equals(Event.EVENT_TYPE_MESSAGE, event.getType())) { | |||
| if (TextUtils.equals(Event.EVENT_TYPE_MESSAGE, event.getType()) || TextUtils.equals(Event.EVENT_TYPE_STICKER, event.getType())) { | |||
element-hq/riot-meta#146
element-hq/riot-android#2097