This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Ignore all whitespace in recovery key #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Dec 21, 2018
There was a problem hiding this comment.
Hi @knaeckeKami,
Thanks for the PR, looks good to me!
Thanks for adding unit test to cover your change :)
Benoit
| - | ||
|
|
||
| Improvements: | ||
| - isValidRecoveryKey() ignores now all whitespace characters, not only spaces |
There was a problem hiding this comment.
It's not necessary to add a new block of changes, the current block at the top of file is already here to add changes for the next release. So you just need to add two lines for you PR (this one and the one in the Test section).
Anyway I will fix this after merging your PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
If the user copies his recovery key in another document, exports it to a PDF file, etc, there might be additional whitespace characters inserted. If he would copy this key and paste in the app to restore his backup, this additional whitespace characters should be ignored.
Pull Request Checklist
Signed-off-by: Martin Kamleithner martin@diagnosia.com