Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Fix room creation params: add the missing state_key in the `initial… #471

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

giomfo
Copy link
Member

@giomfo giomfo commented Jun 21, 2019

…_state` events.

  • The expected format of the state events are an object with type, state_key and content keys set.
  • This was not an actual bug, because a default state_key (A zero-length string) is added by the server

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request updates CHANGES.rst
  • Pull request includes a sign off

…_state` events.

- The expected format of the state events are an object with type, state_key and content keys set.
- This was not an actual bug, because a default state_key  (A zero-length string) is added by the server
@giomfo giomfo requested a review from bmarty June 21, 2019 09:21
Copy link
Contributor

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bmarty added a commit to element-hq/element-android that referenced this pull request Jun 24, 2019
@bmarty bmarty merged commit 6b1ecd4 into develop Jun 24, 2019
@bmarty bmarty deleted the giomfo/fix_initial_state_for_room_creation branch June 24, 2019 20:45
bmarty added a commit to element-hq/element-android that referenced this pull request Jul 1, 2019
bmarty added a commit to element-hq/element-android that referenced this pull request Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants