This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Add "server_name" parameter to the join room request #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuroe
approved these changes
Jul 17, 2019
| * Join a room by its roomAlias | ||
| * | ||
| * @param roomIdOrAlias the room alias | ||
| * @param callback the async callback once the room is joined. The RoomId is provided. |
There was a problem hiding this comment.
Doc for viaServers is missing.
| * @param params the extra join param | ||
| */ | ||
| @POST("join/{roomAliasOrId}") | ||
| Call<RoomResponse> joinRoomByAliasOrId(@Path("roomAliasOrId") String roomAliasOrId, @Body Map<String, Object> params); | ||
| Call<RoomResponse> joinRoomByAliasOrId(@Path("roomAliasOrId") String roomAliasOrId, | ||
| @Query("server_name") List<String> viaServers, |
There was a problem hiding this comment.
Does this annotation create queries like server_name=server1.com&server_name=server2.com when they are several viaServers?
There was a problem hiding this comment.
Yes, see https://square.github.io/retrofit/2.x/retrofit/index.html?retrofit2/http/Query.html
"Passing a List or array will result in a query parameter for each non-null item."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to element-hq/riot-android#3204
Pull Request Checklist