Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of deferPromise #193

Merged
merged 1 commit into from Aug 7, 2020
Merged

Fix usage of deferPromise #193

merged 1 commit into from Aug 7, 2020

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Aug 7, 2020

In the function loadDatabase we use const defer = defer(). This means the second defer is not the imported function, but the undefined variable of the local scope.

@jaller94 jaller94 added the bug label Aug 7, 2020
@jaller94 jaller94 requested a review from Half-Shot August 7, 2020 15:31
@jaller94 jaller94 removed the bug label Aug 7, 2020
@jaller94
Copy link
Contributor Author

jaller94 commented Aug 7, 2020

Removed the label bug as this hadn't been released.

Half-Shot
Half-Shot approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, good catch

@jaller94
Copy link
Contributor Author

jaller94 commented Aug 7, 2020

? CI is cool with me not adding a newsfile?

@jaller94 jaller94 merged commit 4ab4d78 into develop Aug 7, 2020
@jaller94 jaller94 deleted the jaller94-patch-1 branch August 7, 2020 15:33
@Half-Shot
Copy link
Contributor

? CI is cool with me not adding a newsfile?

surprising

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaller94 @Half-Shot