Show replies as embeds #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorunome
reviewed
Oct 25, 2018
src/matrixeventprocessor.ts
Outdated
| @@ -14,6 +14,7 @@ const MaxFileSize = 8000000; | |||
| const MIN_NAME_LENGTH = 2; | |||
| const MAX_NAME_LENGTH = 32; | |||
| const DISCORD_EMOJI_REGEX = /:(\w+):/g; | |||
| const REPLY_REGEX = /> <(@.*:.*)> (.*)\n\n(.*)/; | |||
There was a problem hiding this comment.
This regex could be better, matching MXIDs rather than anything. Also it appears that the reply content is wrapped into ""
src/matrixeventprocessor.ts
Outdated
| sourceEvent.content["m.relates_to"]["m.in_reply_to"]) { | ||
| const sourceMatch = REPLY_REGEX.exec(sourceEvent.content.body); | ||
| if (sourceMatch && sourceMatch.length === REPLY_MATCHES) { | ||
| replyText = sourceMatch[INDEX_REPLY]; |
There was a problem hiding this comment.
message 1:
message 2: <reply to message 1>
message 3: <reply to message 2>
we are replying to message 2, though, and not message 1, so why bother to get that source?
src/matrixeventprocessor.ts
Outdated
| this.SetEmbedAuthor( | ||
| embed, | ||
| sourceEvent.sender, | ||
| await intent.getProfileInfo(sourceEvent.sender), |
There was a problem hiding this comment.
idea: short-circuit @_discord_uiserid:homeserver MXIDs and somehow link their discord profile
This was referenced Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.