Add Discord Announcement channels to allowed bridging types #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the News/Announcement channel type to the list of allowed channel types to bridge between. This can be useful for administrators to centralize announcements between services to reduce the ammount of busy-work that they may need to do. Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>
|
May be useful to add a test. |
|
I'm not sure how to add a test for this kind of stuff, eheh. Most of the code I deal with are core python services that don't exactly rely on external services 😅 Always willing to learn, I just don't know where to start for something out of my field of expertise. |
|
Not that familiar either, but you probably want to make a copy of this test here: And then check whether non-announcement and announcement messages in news channel work. |
Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>
|
Thank you for pointing me in the right direction! Got a test added |
|
Are there any blockers on this PR? Its quite badly needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the News/Announcement channel type to the list of allowed channel types to bridge between. This can be useful for administrators to centralize announcements between services to reduce the ammount of busy-work that they may need to do.
This fixes #774 and it fixes #813, which is a duplicate