Check the displayname of a Matrix user before updating their nick #1157
Conversation
| req.log.warn(`Didn't change nick on the IRC side: ${e}`); | ||
| const intent = this.ircBridge.getAppServiceBridge().getIntent(); | ||
| // Check that the /profile matches the displayname. | ||
| const userProfile = await intent.getProfileInfo(event.state_key, "displayname"); |
There was a problem hiding this comment.
My understanding of the bridges is still poor, but looks like this code is only handled "on join"? So wondering shouldn't it be whenever the matrix side changes display name? And also if this is code that runs for everyone during a startup, will the profile details gets fetched for everyone or just changed names since previous restart?
There was a problem hiding this comment.
Ah, changing displaynames manifests as a resend of the m.room.member[content.membership="join"] event, which is handled by this function every time. onJoin is a slight misnomer
There was a problem hiding this comment.
And also if this is code that runs for everyone during a startup, will the profile details gets fetched for everyone or just changed names since previous restart?
We shouldn't see a join for everyone during startup, so I don't think this is a huge concern.
|
Curious to see how this will relate to #757, since the IRC nick is changed to GuestXYZ when the user gets unidentified (for reasons unknown for now) |
Fixes #1155